Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor open ranges in date_bin_table #24

Merged
merged 1 commit into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sql/timeseries.sql
Original file line number Diff line number Diff line change
Expand Up @@ -585,12 +585,13 @@ BEGIN
SELECT %s
FROM generate_series($2, $3, $1) date_series(date)
LEFT JOIN data
ON data.binned_date = date_series.date;$query$,
ON data.binned_date = date_series.date
WHERE $4 @> date_series.date;$query$,
part_col_name,
target_table_id,
part_col_name,
tl_sql)
USING time_stride, lower(time_range), upper(time_range);
USING time_stride, lower(time_range), upper(time_range), time_range;
RETURN;
END;
$function$;
Expand Down
20 changes: 20 additions & 0 deletions test/expected/basic_usage.out
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,23 @@ ORDER BY 3;
| 1.9000000000000001 | Wed Nov 04 16:00:00 2020 PST
(11 rows)

SELECT last(user_id, value) top_performer,
locf(avg(value)) OVER (ORDER BY event_time),
event_time
FROM date_bin_table(NULL::events, '1 minute',
'(2020-11-04 15:50:00-08, 2020-11-04 16:00:00-08)')
GROUP BY 3
ORDER BY 3;
top_performer | locf | event_time
---------------+--------------------+------------------------------
2 | 1.4 | Wed Nov 04 15:51:00 2020 PST
| 1.4 | Wed Nov 04 15:52:00 2020 PST
2 | 1.5 | Wed Nov 04 15:53:00 2020 PST
| 1.5 | Wed Nov 04 15:54:00 2020 PST
2 | 1.6 | Wed Nov 04 15:55:00 2020 PST
| 1.6 | Wed Nov 04 15:56:00 2020 PST
2 | 1.7 | Wed Nov 04 15:57:00 2020 PST
2 | 1.8 | Wed Nov 04 15:58:00 2020 PST
2 | 1.9000000000000001 | Wed Nov 04 15:59:00 2020 PST
(9 rows)

8 changes: 8 additions & 0 deletions test/sql/basic_usage.sql
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,11 @@ FROM date_bin_table(NULL::events, '1 minute',
'[2020-11-04 15:50:00-08, 2020-11-04 16:00:00-08]')
GROUP BY 3
ORDER BY 3;

SELECT last(user_id, value) top_performer,
locf(avg(value)) OVER (ORDER BY event_time),
event_time
FROM date_bin_table(NULL::events, '1 minute',
'(2020-11-04 15:50:00-08, 2020-11-04 16:00:00-08)')
GROUP BY 3
ORDER BY 3;
Loading