Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to filter logging based off a list of routes #3

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add ability to filter logging based off a list of routes #3

merged 1 commit into from
Aug 14, 2023

Conversation

nhudson
Copy link
Contributor

@nhudson nhudson commented Aug 14, 2023 •
edited
Loading

  • Add implementation around setting up the TraceLogger and a custom filter to exclude routes from the Span. This way we will not log specific routes (eg, liveness, readiness).
  • Add new example showing how to exclude specific routes.
  • Add tests for the new code.
  • Update codeowners file.

fixes: #2

@nhudson nhudson self-assigned this Aug 14, 2023
@nhudson nhudson merged commit a25b383 into main Aug 14, 2023
7 checks passed
@nhudson nhudson deleted the nhudson/add_logger_filter branch August 14, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHend ChuckHend Awaiting requested review from ChuckHend ChuckHend is a code owner

@ianstanton ianstanton Awaiting requested review from ianstanton ianstanton is a code owner

@ryw ryw Awaiting requested review from ryw

@sjmiller609 sjmiller609 Awaiting requested review from sjmiller609

Assignees

@nhudson nhudson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend environment filtering for subscriber
1 participant
@nhudson