Document stack #401
Merged
Document stack #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHStanton
requested review from
sjmiller609,
nhudson,
ianstanton and
ChuckHend
as code owners
ChuckHend
reviewed
Dec 7, 2023
Co-authored-by: Adam Hendel <ChuckHend@users.noreply.github.com>
EvanHStanton
commented
Dec 7, 2023
ChuckHend
approved these changes
Dec 7, 2023
Update yaml name and secretName
…dd-document-stack
ianstanton
reviewed
Dec 12, 2023
ianstanton
approved these changes
Dec 12, 2023
sjmiller609
approved these changes
Dec 12, 2023
Comment on lines
+28
to
+40
| volumes: | ||
| - name: ferretdb-data | ||
| ephemeral: | ||
| volumeClaimTemplate: | ||
| spec: | ||
| accessModes: | ||
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 1Gi | ||
| volumeMounts: | ||
| - name: ferretdb-data | ||
| mountPath: /state |
There was a problem hiding this comment.
it would be nice to not need this (because it would make the container much faster to move across servers) - and I thought we found a way to not include it? In any case, that can be a follow up or maybe it's needed for some reason
| @@ -22,6 +22,8 @@ lazy_static! { | |||
| serde_yaml::from_str(include_str!("templates/vectordb.yaml")).expect("vectordb.yaml not found"); | |||
| pub static ref GEOSPATIAL: Stack = | |||
| serde_yaml::from_str(include_str!("templates/gis.yaml")).expect("gis.yaml not found"); | |||
| pub static ref MONGO_ADAPTER: Stack = serde_yaml::from_str(include_str!("templates/mongo_adapter.yaml")) | |||
There was a problem hiding this comment.
is it too much trouble to name anything that's "Mongo" to "Ferret" for consistency and trademark concerns. Also I think it should just be called "FERRET_DB" or just "FERRET", not including "ADAPTER"
There was a problem hiding this comment.
The functionality provides users a Mongo compatible protocol with Postgres as the backend storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.