-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matcher #431
Update matcher #431
Conversation
@@ -269,7 +269,7 @@ pub fn generate_ingress_tcp_routes( | |||
continue; | |||
} | |||
|
|||
let matcher = format!("{host_matcher} && PathPrefix(`{}`)", path); | |||
let matcher = format!("HostSNI(`{}`)", host_matcher); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to update some assertions in the functional_test_app_service
integration test
) -> Result<(), kube::Error> { | ||
let ingress_api: Api<IngressRouteTCP> = Api::namespaced(client.clone(), ns); | ||
let name = format!("{}-apps", coredb_name); | ||
let name = format!("{}-{}", coredb_name, app_name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
ns, coredb_name, e | ||
); | ||
has_errors = true; | ||
for appsvc in appsvcs.iter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up, let's make sure the expected IngressRouteTCP
resources are created when we have multiple apps that use IngressType: tcp
Note: we observed the app-services-integration-test fail, but pass upon running again. |
Context:
Update IngressRouteTCP Matcher (ingress.rs)
generate_ingress_tcp_routes
matcher to HostSNIUpdate naming convention to be
reconcile_app_services
to define app_nameUpdate assertion (integration_tests.rs)