Update matcher #431
Merged
Update matcher #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstanton
reviewed
Dec 19, 2023
| @@ -269,7 +269,7 @@ pub fn generate_ingress_tcp_routes( | |||
| continue; | |||
| } | |||
|
|
|||
| let matcher = format!("{host_matcher} && PathPrefix(`{}`)", path); | |||
| let matcher = format!("HostSNI(`{}`)", host_matcher); | |||
There was a problem hiding this comment.
You may need to update some assertions in the functional_test_app_service integration test
| ) -> Result<(), kube::Error> { | ||
| let ingress_api: Api<IngressRouteTCP> = Api::namespaced(client.clone(), ns); | ||
| let name = format!("{}-apps", coredb_name); | ||
| let name = format!("{}-{}", coredb_name, app_name); |
ianstanton
reviewed
Dec 19, 2023
| ns, coredb_name, e | ||
| ); | ||
| has_errors = true; | ||
| for appsvc in appsvcs.iter() { |
There was a problem hiding this comment.
As a follow-up, let's make sure the expected IngressRouteTCP resources are created when we have multiple apps that use IngressType: tcp
EvanHStanton
requested review from
sjmiller609,
nhudson and
ChuckHend
as code owners
|
Note: we observed the app-services-integration-test fail, but pass upon running again. |
ChuckHend
reviewed
Dec 19, 2023
ianstanton
approved these changes
Dec 19, 2023
ChuckHend
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Update IngressRouteTCP Matcher (ingress.rs)
generate_ingress_tcp_routesmatcher to HostSNIUpdate naming convention to be
reconcile_app_servicesto define app_nameUpdate assertion (integration_tests.rs)