Add config to set target database for metric query #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhudson
requested review from
sjmiller609,
ianstanton and
ChuckHend
as code owners
nhudson
commented
Dec 21, 2023
| @@ -262,7 +262,7 @@ pub fn generate_ingress_tcp_routes( | |||
| let mut routes: Vec<IngressRouteTCPRoutes> = Vec::new(); | |||
| for route in routings.iter() { | |||
| match route.ingress_path.clone() { | |||
| Some(path) => { | |||
| Some(_path) => { | |||
There was a problem hiding this comment.
This is to fix a clippy warning where path isn't being used.
ChuckHend
reviewed
Dec 21, 2023
| @@ -73,6 +73,8 @@ spec: | |||
| - total_messages: | |||
| description: Total number of messages that have passed into the queue. | |||
| usage: GAUGE | |||
| target_databases: | |||
There was a problem hiding this comment.
Do we also need to add this to the Stack definition at src/stacks/templates?
There was a problem hiding this comment.
No it will add it automatically when reconciling the ConfigMap. Though, it wouldn't hurt to add it to the stack definition
ChuckHend
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issues where the default query for metrics is using the correct database.
This config is taken directly from the CNPG docs
Fixes: TEM-2666