-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config to set target database for metric query #450
Conversation
@@ -262,7 +262,7 @@ pub fn generate_ingress_tcp_routes( | |||
let mut routes: Vec<IngressRouteTCPRoutes> = Vec::new(); | |||
for route in routings.iter() { | |||
match route.ingress_path.clone() { | |||
Some(path) => { | |||
Some(_path) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to fix a clippy warning where path
isn't being used.
@@ -73,6 +73,8 @@ spec: | |||
- total_messages: | |||
description: Total number of messages that have passed into the queue. | |||
usage: GAUGE | |||
target_databases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to add this to the Stack definition at src/stacks/templates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it will add it automatically when reconciling the ConfigMap
. Though, it wouldn't hurt to add it to the stack definition
To fix issues where the default query for metrics is using the correct database.
This config is taken directly from the CNPG docs
Fixes: TEM-2666