-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conductor
: Add support for Azure Backup and Restore
#980
Conversation
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
3eb0e4e
to
ed3c480
Compare
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to add a check like these to make sure you can't set aws or gcp also at the same time. Other than that LGTM! Great work!
// Error and exit if both IS_CLOUD_FORMATION and IS_GCP are set to true
if is_cloud_formation && is_gcp {
panic!("Cannot have both IS_CLOUD_FORMATION and IS_GCP set to true");
}
// Error and exit if IS_GCP is true and GCP_PROJECT_ID or GCP_PROJECT_NUMBER are not set
if is_gcp && (gcp_project_id.is_empty() || gcp_project_number.is_empty()) {
panic!("GCP_PROJECT_ID and GCP_PROJECT_NUMBER must be set if IS_GCP is true");
}
Signed-off-by: Ian Stanton <ian@tembo.io>
Thanks, good suggestion! Addressed here a4b9cd5 |
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
This PR adds steps for creating the Azure 'IAM' resources necessary for instances to perform backup / restore with Azure Blob Storage.
When an instance using Azure is created:
CoreDB
specWhen an instance using Azure is deleted:
Note: This only supports the backup archive bucket at the moment. We'll add support for the storage archive bucket as a follow-up