-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-3257: Updates Task-Queue metrics coverage to reduce confusion #3156
Open
fairlydurable
wants to merge
2
commits into
main
Choose a base branch
from
EDU-3257
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 15, 2024 16:38
d152606
to
8118f72
Compare
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 15, 2024 17:43
8118f72
to
d3b9bd4
Compare
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 15, 2024 17:46
d3b9bd4
to
d215d24
Compare
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 15, 2024 17:47
d215d24
to
7a317d3
Compare
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 15, 2024 17:48
7a317d3
to
3292dbc
Compare
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 15, 2024 17:53
3292dbc
to
7091894
Compare
fairlydurable
force-pushed
the
EDU-3257
branch
2 times, most recently
from
October 15, 2024 17:58
0d4fdee
to
07b9b1c
Compare
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 15, 2024 18:01
07b9b1c
to
67a4c73
Compare
fairlydurable
force-pushed
the
EDU-3257
branch
2 times, most recently
from
October 15, 2024 18:03
38d7af4
to
2fa8d10
Compare
atihkin
reviewed
Oct 15, 2024
atihkin
reviewed
Oct 15, 2024
atihkin
reviewed
Oct 15, 2024
atihkin
reviewed
Oct 15, 2024
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 16, 2024 21:02
2fa8d10
to
f5328b6
Compare
- "Describe" returns info that isn't metrics - METRIC ACCURACY warnings are unnecessary clutter and scary
fairlydurable
force-pushed
the
EDU-3257
branch
from
October 16, 2024 21:19
f5328b6
to
cc6b544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expert: @atihkin