fix(cpp): lower CUDA complex casts with cuComplex helpers - #17
Merged
Conversation
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observation
CUDA compilation fails when a scalar initializes a complex value. Zero fill, for example, generated:
NVRTC rejects this because CUDA complex types are C structs without converting constructors. The same lowering also breaks scalar/complex and
cf32/cf64conversions.Issue
Assign::format_scalaremittedTargetType(input)for conversions that involve CUDA complex types. Complex conversions must construct or extract components explicitly. Complex-to-bool also inspected only the real component, so0 + 1ibecame false and disagreed with constant folding.Fix
make_cuFloatComplexormake_cuDoubleComplexThe PR also includes two mechanical fixes required by the current Clippy pass.
Verification
cargo test -p t4a-cubecl-cpp --libcargo test -p t4a-cubecl-ir --libcargo test -p t4a-cubecl-core --libcargo clippy --no-deps -- --deny warningscargo fmt --all -- --check