Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated sync from github.com/tensorflow/tensorflow #2110

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

TFLM-bot
Copy link
Collaborator

@TFLM-bot TFLM-bot commented Jul 7, 2023

BUG=automated sync from upstream
NO_CHECK_TFLITE_FILES=automated sync from upstream

advaitjain
advaitjain previously approved these changes Jul 7, 2023
In upstream TFLite, op_macros.h contains a TF_LITE_ASSERT macro that
would print the failed assertion and then call abort(). This macro was
removed from TFLM's version of op_macros.h because it relied on stdlib
functions (namely, fprintf). As there were no usages of TF_LITE_ASSERT
in shared code, this was not a problem. However, the latest sync
introduces a usage of it within shared code, breaking the build. This
commit adds a TFLM-friendly implementation of TF_LITE_ASSERT using
MicroPrintf for the implementation.
@rascani
Copy link
Contributor

rascani commented Jul 12, 2023

@advaitjain PTAL

@mergify mergify bot merged commit 33b54b3 into main Jul 12, 2023
70 of 71 checks passed
@mergify mergify bot deleted the sync-from-upstream-tf branch July 12, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants