Skip to content

Commit

Permalink
Remove warnings about using lifetime fields in NodeExecutionOptions.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 608670119
  • Loading branch information
kmonte authored and tfx-copybara committed Feb 20, 2024
1 parent b0030a7 commit 4f5575a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions tfx/dsl/experimental/node_execution_options/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,15 @@ class NodeExecutionOptions:
# new stateful working dir will be created for every new execution.
reset_stateful_working_dir: bool = False

# This is an experimental feature to enable "end nodes" in a pipeline to
# This is a feature to enable "end nodes" in a pipeline to
# support resource lifetimes. If this field is set then the node which this
# NodeExecutionOptions belongs to will run during pipeline finalization if the
# "lifetime_start" has run succesfully.
# "lifetime_start" node has run succesfully.
# Pipeline finalization happens when:
# 1. All nodes in the pipeline completed, this is the "happy path".
# 2. A user requests for the pipeline to stop
# 3. A node fails in the pipeline and it cannot continue executing.
# This should be the id of the node "starting" a lifetime.
# If you want to use this feature please contact kmonte@ first.
lifetime_start: Optional[str] = None

# TFX only, do not set manually.
Expand Down
5 changes: 2 additions & 3 deletions tfx/proto/orchestration/pipeline.proto
Original file line number Diff line number Diff line change
Expand Up @@ -622,16 +622,15 @@ message NodeExecutionOptions {
// Current behavior for ASYNC pipelines is undefined.
// TODO(b/298253165)
message ResourceLifetime {
// This is an experimental feature to enable "end nodes" in a pipeline to
// This is a feature to enable "end nodes" in a pipeline to
// support resource lifetimes. If this field is set then the node which this
// NodeExecutionOptions belongs to will run during pipeline finalization if
// the "lifetime_start" has run succesfully.
// the "lifetime_start" node has run succesfully.
// Pipeline finalization happens when:
// 1. All nodes in the pipeline completed, this is the "happy path".
// 2. A user requests for the pipeline to stop
// 3. A node fails in the pipeline and it cannot continue executing.
// This should be the id of the node "starting" a lifetime.
// If you want to use this feature please contact kmonte@ first.
oneof paired_lifetime {
// If set then the node this NodeExecutionOptions belongs to marks the end
// of some lifetime.
Expand Down

0 comments on commit 4f5575a

Please sign in to comment.