Skip to content

Commit

Permalink
Remove Env.get_base_dir()
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 654932257
  • Loading branch information
kmonte authored and tfx-copybara committed Jul 22, 2024
1 parent 2e66d21 commit d120c63
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
7 changes: 0 additions & 7 deletions tfx/orchestration/experimental/core/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ def get_orchestration_options(
) -> orchestration_options.OrchestrationOptions:
"""Gets orchestration options for the pipeline."""

@abc.abstractmethod
def get_base_dir(self) -> Optional[str]:
"""Returns the base directory for the pipeline."""

@abc.abstractmethod
def label_and_tag_pipeline_run(
self, mlmd_handle, pipeline_id, pipeline_run_id, labels, tags
Expand Down Expand Up @@ -161,9 +157,6 @@ def get_orchestration_options(
del pipeline
return orchestration_options.OrchestrationOptions()

def get_base_dir(self) -> Optional[str]:
return None

def label_and_tag_pipeline_run(
self, mlmd_handle, pipeline_id, pipeline_run_id, labels, tags
) -> None:
Expand Down
3 changes: 0 additions & 3 deletions tfx/orchestration/experimental/core/env_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ class _TestEnv(env.Env):
def get_orchestration_options(self, pipeline):
raise NotImplementedError()

def get_base_dir(self):
raise NotImplementedError()

def label_and_tag_pipeline_run(
self, mlmd_handle, pipeline_id, pipeline_run_id, labels, tags
):
Expand Down

0 comments on commit d120c63

Please sign in to comment.