Perform atomic writes for resulting service discovery YAML file #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 9, 2022 12:34
We were seeing parsing error messages in Prometheus, as below: ``` ts=2022-02-08T17:59:59.920Z caller=file.go:337 level=error component="discovery manager scrape" discovery=file msg="Error reading file" path=/etc/prometheus/prometheus_ecs_container_endpoints.123456789.yml err="yaml: line 186: could not find expected ':'" ``` On manual inspection of the files, they appeared complete and could be parsed. This indicates that the file is not complete at the time Prometheus is reading it. The https://github.com/natefinch/atomic library allows writing the service discovery file, and then atomically moving it in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform atomic writes for resulting service discovery YAML file
We were seeing parsing error messages in Prometheus, as below:
On manual inspection of the files, they appeared complete and could be parsed.
This indicates that the file is not complete at the time Prometheus is reading it.
The https://github.com/natefinch/atomic library allows writing the service discovery file,
and then atomically moving it in place.