Change foreman_katello_repositories ignorable_content to list #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitkeks
requested changes
Jun 26, 2024
Comment on lines
+352
to
+358
| if ignorableContent, ok := d.GetOk("ignorable_content"); ok { | ||
| casted := ignorableContent.([]interface{}) | ||
| var ignorableContentList []string | ||
| for _, item := range casted { | ||
| ignorableContentList = append(ignorableContentList, item.(string)) | ||
| } | ||
| repo.IgnorableContent = ignorableContentList |
There was a problem hiding this comment.
Why don't you directly assert to []string here? Suggestion also adds ok to check, else it may panic.
Like this:
Suggested change
| if ignorableContent, ok := d.GetOk("ignorable_content"); ok { | |
| casted := ignorableContent.([]interface{}) | |
| var ignorableContentList []string | |
| for _, item := range casted { | |
| ignorableContentList = append(ignorableContentList, item.(string)) | |
| } | |
| repo.IgnorableContent = ignorableContentList | |
| if ignorableContent, ok := d.GetOk("ignorable_content"); ok { | |
| ignorableContentList, ok := ignorableContent.([]string) | |
| if ok { | |
| repo.IgnorableContent = ignorableContentList | |
| } | |
|
Sorry I have exams, it will be a while before i have more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ignorable content parsing when its an empty list