Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing value 'mirror_complete' to mirroring_policy param. #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vhsantos
Copy link
Contributor

@vhsantos vhsantos commented Jun 24, 2024

As mentioned on the issue #170, mirroring_police parameter from repositories accept 03 values (additive, mirror_complete, mirror_content_only), but the mirror_complete was missing.

Additional, updated the documentation to include this parameter too.

@vhsantos
Copy link
Contributor Author

Hi @lhw

may you can check and approve theses simple PR too ??

@lhw
Copy link
Contributor

lhw commented Aug 1, 2024

Could you use the autodoc tool for the documentation. This is not something that is touched manually. After that please ping me. But I do have to find a better way to get notifications on GH. They just get lost among my work notifications

Copy link
Collaborator

@bitkeks bitkeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, three fields according to Katello API docs: Must be one of: additive, mirror_complete, mirror_content_only.

Copy link
Collaborator

@bitkeks bitkeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After re-testing this, just adding the parameter is not enough.

Spec says: Mirror Complete: a sync behaves exactly like "Mirror Content Only", but also mirrors metadata as well. This is the fastest method, and preserves repository signatures, but is only supported by yum and not by all upstream repositories.

This only works on yum-based repositories and throws an error on deb repositories. So we'll need to add a check for the repo type and only then allow mirror_complete to be used on yum repos.

@bitkeks bitkeks assigned vhsantos and unassigned lhw Aug 8, 2024
@bitkeks bitkeks added enhancement New feature or request help wanted Extra attention is needed labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants