Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE for Developers] Add And Configure ESlint and Prettier #81

Merged

Conversation

ArkadiK94
Copy link
Contributor

@ArkadiK94 ArkadiK94 commented Oct 28, 2023

Why: it is very important to have Eslint for errors and Prettier for code format
How: Add Eslint and Prettier configure and solve bugs that it alerted about
What: Add And Configure ESlint and Prettier

Fixes Issue

Closes #77

Changes proposed

configure ESlint and Prettier similar as in the "TheCyberHUB" project , for better development experience
I used a package eslint-config-universe because it is the recommended one from the expo docs
https://docs.expo.dev/guides/using-eslint/

Screenshots

There has not been made a visual change

Note to reviewers

The changes in files and some files extension was needed for the ESlint to pass.

Code of Conduct

  • By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation. - I don't know,however I added some styles in package.json
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

Why: it is very important to have Eslint for errors and Prettier for code format
How: Add Eslint and Prettier configure and solve bugs that it alerted about
What: Add And Configure ESlint and Prettier
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

@ArkadiK94
Copy link
Contributor Author

@kabir0x23

@ArkadiK94
Copy link
Contributor Author

I am a little bit confused, you have some files that use typescript so I added to eslint the right configurations. However, you also have files that don't use typescript. Do you want to use typescript in the project or not? Do you want me to open an issue about this topic? @kabir0x23

@kabir0x23
Copy link
Member

I am a little bit confused, you have some files that use typescript so I added to eslint the right configurations. However, you also have files that don't use typescript. Do you want to use typescript in the project or not? Do you want me to open an issue about this topic? @kabir0x23

I think ts is only being used in 1 or 2 components

if we convert the project into the type it will take time...

will think, and u can create issues according to what u think will be better for project

thank you,

Copy link
Member

@kabir0x23 kabir0x23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions @ArkadiK94

Will review and merge it by today.

@ArkadiK94 ArkadiK94 mentioned this pull request Nov 3, 2023
1 task
Copy link
Member

@kabir0x23 kabir0x23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrbutions,

and apllogise for delay.

@ArkadiK94
Copy link
Contributor Author

ArkadiK94 commented Nov 4, 2023

It is ok. I opened a new issue about typescript #84 , however, in this pr, I changed some files to tsx and I am not sure if I should leave it or change to jsx. Do you want to merge this pr and think about it in the relevant issue?
@kabir0x23

@ArkadiK94
Copy link
Contributor Author

ArkadiK94 commented Nov 8, 2023

@kabir0x23 Could you merge this pr and we will talk about ts in the relevant pr?

@kabir0x23
Copy link
Member

@kabir0x23 Could you merge this pr and we will talk about ts in the relevant pr?

yes sure

Thanks for your contrbutions,

and apllogise for delay again.

@kabir0x23 kabir0x23 merged commit 7b5b621 into th3cyb3rhub:main Nov 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE for Developers] Configure ESlint and Prettier
2 participants