D frameworks #6488

cyrusmsk · 2023-07-04T20:07:12Z

Added 3 more frameworks:

arsd:cgi
handy-https
lighttp
Also small changes to archttp and Docker file (for latest version of LDC).

Please review and test to approve the PR into master branch.

Two authors of framework (handy and arsd:cgi) agreed to add their framework to bench. I also added threads to archttp - probably it will improve results. Lighttp - simple and straightforward framework that was abandoned by the original author, bit it is still working. Also I propose to use dlangchina containter for Docker - it should use more modern version of LDC compiler. At least for the time when official containers for D will be ready (WIP now)

2.096 - is the version of DMD reference compiler. LDC - LLVM backend has different structure of the semver.

waghanza · 2023-07-05T07:18:15Z

@adamdruppe @andrewlalis @Kripth we are going to add those framework in here. is it ok for you ?

d/Dockerfile

waghanza · 2023-07-05T07:22:19Z

d/archttp/dub.json

@@ -1,7 +1,9 @@
 {
  "name": "server",
  "dependencies": {
-    "archttp": "~>1.1.1"
+    "archttp": "~>1.1.1",
+    "mir-cpuid": "~>1.2.10"


is it a common usage ? I mean physical resources handling should not be a part of the framework / language ?

Probably it will work without it. I've just took it from other repo: https://github.com/tchaloupka/httpbench/tree/master/dlang/archttp

seems like a hack for me, I prefer no to, but let's check with @zoujiaqing

I propose to try with this one. In case it doesn't give any value - we can remove it.

d/cgi/config.yaml

waghanza · 2023-07-05T07:24:11Z

d/config.yaml

@@ -1,5 +1,5 @@
 language:
-  version: 2.096
+  version: 1.32.2


?

ℹ️ Not sure how to determine language version

D has several compilers.
DMD has versions 2.XXX - now it is 2.104 https://dlang.org/download.html#dmd
LDC (based on LLVM) has different versions. The latest is 1.32.2 https://github.com/ldc-developers/ldc/releases

If using ldc package of debian, how can we be sure of version number (of the language) ?

I just saw that C uses Debian as well. So you are right - we can rely only on version from the package. Could we use it as temporary decision? While the updated versions of official (or at least community-driven) docker images are under preparation?

d/handy/config.yaml

d/lighttp/config.yaml

adamdruppe · 2023-07-05T12:02:12Z

yeah i think benchmarks are generally silly and useless (they are so far away from any real world concerns) but i don't mind them being there.

cyrusmsk · 2023-07-05T12:41:20Z

@adamdruppe @andrewlalis @Kripth we are going to add those framework in here. is it ok for you ?

The approve from Andrew is here: andrewlalis/handy-httpd#20

Also added fix for version numbers as suggested

Check if it works without it

Move Docker to latest Alpine. And install LDC in Docker file

Added dub

Mark as build

cyrusmsk · 2023-07-18T19:23:12Z

@waghanza do you know the error with wrong URL?
docker run -p 3000:3000 -td d.archttp.default > d/archttp/cid-default.txt
docker inspect cat d/archttp/cid-default.txt | jq -r '.[0].NetworkSettings.IPAddress' > d/archttp/ip-default.txt
curl --retry 5 --retry-delay 5 --retry-max-time 180 --retry-connrefused http://cat d/archttp/ip-default.txt:3000 -v

Closing connection -1
curl: (3) URL using bad/illegal format or missing URL

Don't know how to fix it.

waghanza · 2023-07-18T19:29:33Z

Maybe if server is not listening to 0.0.0.0 inside the container, and on port 3000 @cyrusmsk

cyrusmsk · 2023-07-18T19:36:35Z

It seems problem in Docker configuration. If I will use old ubuntu-based two solutions passed tests successfully. But now I'm trying to use Alpine image and faced with this problem.

cyrusmsk · 2023-07-18T19:58:33Z

Maybe if server is not listening to 0.0.0.0 inside the container, and on port 3000 @cyrusmsk

is it possible to echo/cat the file 'd/archttp/ip-default.txt' somehow with Docker command?
I can't understand where is everything is running.
Who is giving CMD command?

Forgot to add dub

change ip for handy_http

Added SUCCESS statuses for response for handy_http

cyrusmsk · 2023-07-18T21:34:52Z

Ok, with last commit everything passed tests: https://github.com/cyrusmsk/web-frameworks/actions/runs/5592528052/jobs/10225103834
Please review now @waghanza

waghanza

Are you sure that ldc provided by debian side use d lang version 1.32 @cyrusmsk ?
https://packages.debian.org/unstable/ldc

Change language version and move to Devian bookworm

cyrusmsk · 2023-07-19T17:48:13Z

Are you sure that ldc provided by debian side use d lang version 1.32 @cyrusmsk ?
https://packages.debian.org/unstable/ldc

Fixed to 1.30.0. And also I saw that you are planning to move other Debian based images to Bookworm, so I've change the container to Bookworm as well. All tests are passed https://github.com/cyrusmsk/web-frameworks/actions/runs/5602125606 in local repo.

waghanza · 2023-07-19T19:14:42Z

Could you use multi-layer container @cyrusmsk ?

added static files copy

change copy command

cyrusmsk · 2023-07-19T20:46:26Z

Could you use multi-layer container @cyrusmsk ?

Updated to multi-stage container. But because D need runtime - it still required ldc package to run. Probably it is possible to build static executables, but I haven't tested them for HTTPs frameworks. Test locally run here https://github.com/cyrusmsk/web-frameworks/actions/runs/5603841227

cyrusmsk · 2023-07-21T16:55:04Z

Hi @waghanza
Anything else should be added to be merged? Please let me know

cyrusmsk added 2 commits July 5, 2023 00:03

Update config.yaml

f0d31b6

2.096 - is the version of DMD reference compiler. LDC - LLVM backend has different structure of the semver.

cyrusmsk requested a review from waghanza as a code owner July 4, 2023 20:07

waghanza requested changes Jul 5, 2023

View reviewed changes

cyrusmsk added 12 commits July 5, 2023 16:51

Fixed typo

9066cbb

Also added fix for version numbers as suggested

Remove nobounds and native

76ffee9

Check if it works without it

Merge remote-tracking branch 'upstream/master' into d_frameworks

4e3c5b6

Move to old docker image

3602201

Update Dockerfile

7d62c79

Move Docker to latest Alpine. And install LDC in Docker file

Dub fixed

8da57d5

Added dub

Added gcc

bd79e47

added Musl-dec

fee0ebe

Update Dockerfile

5890ef9

Mark as build

Alpine for run

38b1908

fix type

109fc37

Added wrokdir to run

24372c8

cyrusmsk added 6 commits July 19, 2023 00:09

Make everything in one Docker Image

800f424

Move back to Debian

fabf784

Added dub to Debian

81510e8

Forgot to add dub

Extra deps for vibe.d in Debian

0332e3d

Update app.d

b93dfaf

change ip for handy_http

Update app.d

f4da8eb

Added SUCCESS statuses for response for handy_http

waghanza requested changes Jul 19, 2023

View reviewed changes

Fix version

98c3a00

Change language version and move to Devian bookworm

cyrusmsk added 5 commits July 19, 2023 23:59

Make multi-stage container

56312cd

fix typo

183d78c

Update Dockerfile

12add80

added static files copy

Changed source of executable

fcb786f

Update Dockerfile

a182103

change copy command

waghanza approved these changes Jul 20, 2023

View reviewed changes

waghanza mentioned this pull request Jul 21, 2023

Update web.csproj #6535

Merged

waghanza merged commit 3de2fb9 into the-benchmarker:master Jul 21, 2023
19 checks passed

cyrusmsk deleted the d_frameworks branch July 21, 2023 17:34

waghanza mentioned this pull request Sep 4, 2023

D frameworks 2 #6687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

D frameworks #6488

D frameworks #6488

cyrusmsk commented Jul 4, 2023

waghanza commented Jul 5, 2023

waghanza Jul 5, 2023

cyrusmsk Jul 5, 2023

waghanza Jul 5, 2023

cyrusmsk Jul 16, 2023

waghanza Jul 5, 2023

cyrusmsk Jul 5, 2023

waghanza Jul 19, 2023

cyrusmsk Jul 19, 2023

adamdruppe commented Jul 5, 2023

cyrusmsk commented Jul 5, 2023

cyrusmsk commented Jul 18, 2023

waghanza commented Jul 18, 2023

cyrusmsk commented Jul 18, 2023

cyrusmsk commented Jul 18, 2023

cyrusmsk commented Jul 18, 2023

waghanza left a comment

cyrusmsk commented Jul 19, 2023

waghanza commented Jul 19, 2023

cyrusmsk commented Jul 19, 2023

cyrusmsk commented Jul 21, 2023

D frameworks #6488

D frameworks #6488

Conversation

cyrusmsk commented Jul 4, 2023

waghanza commented Jul 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamdruppe commented Jul 5, 2023

cyrusmsk commented Jul 5, 2023

cyrusmsk commented Jul 18, 2023

waghanza commented Jul 18, 2023

cyrusmsk commented Jul 18, 2023

cyrusmsk commented Jul 18, 2023

cyrusmsk commented Jul 18, 2023

waghanza left a comment

Choose a reason for hiding this comment

cyrusmsk commented Jul 19, 2023

waghanza commented Jul 19, 2023

cyrusmsk commented Jul 19, 2023

cyrusmsk commented Jul 21, 2023