add uwebsockets.js

[jim-king-2000]

I wanna add uwebsockets.js to the benchmarks since it defeats all of the other frameworks here.

[jim-king-2000]

It seems that the npm here does not support github:uNetworking/uWebSockets.js#v20.30.0. Any idea?

[waghanza]

It seems that the npm here does not support github:uNetworking/uWebSockets.js#v20.30.0. Any idea?
git is not installed

however @jim-king-2000, the author of uws (@uNetworkingAB) does not want to be included in here
#1064

[jim-king-2000]

however @jim-king-2000, the author of uws (@uNetworkingAB) does not want to be included in here
#1064

Could you please check it with him again? If he insists to not be included, we have to close this PR.

[waghanza]

lets way about 10 days if no reaction and we will merge, but I'm sure he will :-)

[jim-king-2000]

lets way about 10 days if no reaction and we will merge

Sure.

but I'm sure he will :-)

That would be better.

[jim-king-2000]

Any update?

[waghanza]

When running pm2-runtime start app.js -i max I have

(node:27) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/usr/src/app/app.js:1
import { App } from 'uWebSockets.js';
^^^^^^
SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at /usr/local/lib/node_modules/pm2/lib/ProcessContainer.js:304:25
    at wrapper (/usr/local/lib/node_modules/pm2/node_modules/async/internal/once.js:12:16)
    at next (/usr/local/lib/node_modules/pm2/node_modules/async/waterfall.js:96:20)
    at /usr/local/lib/node_modules/pm2/node_modules/async/internal/onlyOnce.js:12:16

[jim-king-2000]

When running pm2-runtime start app.js -i max I have

(node:27) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/usr/src/app/app.js:1
import { App } from 'uWebSockets.js';
^^^^^^
SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at /usr/local/lib/node_modules/pm2/lib/ProcessContainer.js:304:25
    at wrapper (/usr/local/lib/node_modules/pm2/node_modules/async/internal/once.js:12:16)
    at next (/usr/local/lib/node_modules/pm2/node_modules/async/waterfall.js:96:20)
    at /usr/local/lib/node_modules/pm2/node_modules/async/internal/onlyOnce.js:12:16

Change app.js to app.mjs.

[jim-king-2000]

Why did it still fail?

[jim-king-2000]

@waghanza Would you please take a look at it? What is the error message?

[waghanza]

(node:166) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/usr/src/app/app.js:1
import { App } from "uWebSockets.js";
^^^^^^
SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at /usr/local/lib/node_modules/pm2/lib/ProcessContainer.js:304:25
    at wrapper (/usr/local/lib/node_modules/pm2/node_modules/async/internal/once.js:12:16)
    at next (/usr/local/lib/node_modules/pm2/node_modules/async/waterfall.js:96:20)
    at /usr/local/lib/node_modules/pm2/node_modules/async/internal/onlyOnce.js:12:16

@jim-king-2000

[jim-king-2000]

Success. What about the attitude of the author of uws?

[waghanza]

We are going to include uws in here @uNetworkingAB

[jim-king-2000]

@waghanza Let's just do it. We could disable it if there is any concern from the author.

[cyrusmsk]

I think adding C++ package is even more interesting than js

[waghanza]

Be my guest @cyrusmsk

[jim-king-2000]

I think adding C++ package is even more interesting than js

Maybe I could try to add uws cpp.