-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix automatic sort of Composite
items in fixed containers
#47
base: master
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 75dd95b:
|
Thanks for working on this @EricRibeiro! I'll take a look at it this weekend (hopefully). |
Size Change: 0 B Total Size: 257 kB ℹ️ View Unchanged
|
I'm also hitting this issue on a regular basis, it can be quite jarring on a long page – thanks for taking on the fix! |
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 230 230
Lines 3509 3509
Branches 955 955
=======================================
Hits 3338 3338
Misses 170 170
Partials 1 1
Continue to review full report at Codecov.
|
@@ -5,7 +5,7 @@ import { Item } from "./types"; | |||
|
|||
type SetItems = (items: Item[]) => void; | |||
|
|||
function setItemsBasedOnDOMPosition(items: Item[], setItems: SetItems) { | |||
function mutateItemsBasedOnDOMPosition(items: Item[], setItems: SetItems) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reasoning behind the mutate
name?
Closes #46
How to test?
Does this PR introduce breaking changes?
No