feat(content): add async await js article #109
Conversation
| (async () => { | ||
| let data = await foo(); | ||
| console.log(data); // "foo" | ||
| })(); |
There was a problem hiding this comment.
Might be a good idea to to add a single link to the IIFE you're using here.
There was a problem hiding this comment.
I'm not sure what you mean here? Do you mean add a link to what an IIFE is?
There was a problem hiding this comment.
Yeah, either that or just turn it into a regular function call. I think we probably want to keep the examples as simple as possible in every way
There was a problem hiding this comment.
Yea, I get what you're saying, but to me an IIFE here makes sense as people can copy / paste the code and it will just work. If it was a normal function instead, they would have to make an async function themselves if they wanted to run the code and check the output, which was the reason I used it here. I'll see if I can find a good link to put in here maybe that can explain them, or maybe even write an explanation in some other article here for how they work.
| } | ||
| ``` | ||
|
|
||
| ## Beginner Mistakes |
There was a problem hiding this comment.
This section should absolutely be mentioning the mistake of wrapping promises inside new Promise, that's something I've seen too many times.
There was a problem hiding this comment.
Although we might just want to edit the original promise article for that instead, I guess I could see that going either way.
There was a problem hiding this comment.
Good point - I guess adding in to the original promise article might be better here, as I have that article listed in the recommended reading section, and can add that one there explicitly.
People should read that one first, so the way I was approaching this section here was like an addition to the common mistakes from the original promise article, rather than adding them in both places.
| created_at: "2019/10/01" | ||
| title: Async Await | ||
| recommended_reading: | ||
| - javascript/promises |
There was a problem hiding this comment.
this links to a 404 (at least for now), can we link to javascript/promises/intro?
There was a problem hiding this comment.
cool, fixed that now, thanks.
|
By the way, ignore the codacy check, we are not using it atm and it's improperly set up (ping @Xetera). Could you please rebase against latest master, and squash your 3 commits? |
|
@veksen will do. I have just rebased against master and squashed the commits. Let me know if I need to do anything else. |
|
TY! It's good for me, will merge in a bit. Little advice, if you can create a new branch when you make PRs on your fork, it makes it a lot easier if anybody wants to use your forked branch locally (to make edits, or simply checkout). Ty for the contribution! |
|
@Xetera merging this, if we want further changes, let's introduce a new PR |
feat(content): add Async / Await JS article
Add a basic article in the Promises section of Javascript on Async / Await.
There are possibly scenarios I have missed or not properly explained here, as it is my first contribution to the site. If you need me to make any changes feel free to suggest.
Added:
Referenced in #87