Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake/CRYPTO - set CMAKE_REQUIRED_INCLUDES #1110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justsmth
Copy link

@justsmth justsmth commented Dec 8, 2023

When using a custom CRYPTO library, that library's include path should be set to the CMAKE_REQUIRED_INCLUDES prior to check_include_file.

CMAKE_REQUIRED_INCLUDES
A ;-list of header search paths to pass to the compiler. These will be the only header search paths used--the contents of the INCLUDE_DIRECTORIES directory property will be ignored.

Testing

  • Setup
cd `mktemp -d`
git clone https://github.com/aws/aws-lc.git
git clone https://github.com/the-tcpdump-group/tcpdump.git
# Then... change branch or apply this PR as a patch to tcpdump
  • Build/Install AWS-LC
mkdir aws-lc-build aws-lc-install
cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=./aws-lc-install -B ./aws-lc-build -S ./aws-lc
cmake --build ./aws-lc-build --target install -j 4
mkdir -p tcpdump-build
cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=`pwd`/aws-lc-install -S ./tcpdump -B ./tcpdump-build
cmake --build ./tcpdump-build --target tcpdump
cmake --build ./tcpdump-build --target check

Several tests may fail until PR #1351 is merged.

@justsmth
Copy link
Author

I updated the description to show how to setup the build to use (e.g.) AWS-LC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant