Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fr.json #134

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Update fr.json #134

merged 3 commits into from
Mar 28, 2024

Conversation

Resxt
Copy link
Contributor

@Resxt Resxt commented Mar 23, 2024

Changed "balados" (not a real word) to "podcasts"
Added "hideAudiobooks" translation

Changed "balados" (not a real word) to "podcasts"
Added "hideAudiobooks" translation
@theRealPadster
Copy link
Owner

When I google "balados", it seems to mean podcasts?
image

@theRealPadster
Copy link
Owner

If it's a Canadian/Quebec French thing, can you add an override to a separate locale file? Like how we have "en" and "en-US"? They have different languages in Spotify.
image

@Resxt
Copy link
Contributor Author

Resxt commented Mar 24, 2024

I don't speak or understand anything canadian so no, I would mess it up.

My opinion is that they still speak french and understand it. Metropolitan french people don't understand canadian but canadians understand "regular french" because their language is based on it.

The words used for this translation are very simple french and they will understand it. Even more since "podcasts" is widely known and since english is like second nature in a lot of places there

@theRealPadster
Copy link
Owner

You don't need to include every string, I just meant to move the current "balados" ones to a French Canadian file, and then we update the main fr.json.

Copy link
Owner

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need the changed keys. It will default to the regular "fr.json" version for anything missing.

src/locales/fr-CA.json Outdated Show resolved Hide resolved
@theRealPadster theRealPadster merged commit fdb29d6 into theRealPadster:main Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants