Skip to content

Commit

Permalink
Update plugin.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
Toby authored Feb 6, 2022
1 parent 51f16a2 commit 1a01bdc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions plugin.yml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: oh-my-pmmp
author: MintoD
version: 1.0.0
version: 1.1.0
description: A plugin manager for OhMyPMMP
api: 4.0.0
main: thebigcrafter\OhMyPMMP\OhMyPMMP
Expand All @@ -15,4 +15,4 @@ permissions:
default: op
ohmypmmp.upgrade.cmd:
description: Allow players to upgrade plugin
default: op
default: op

1 comment on commit 1a01bdc

@Ifera
Copy link

@Ifera Ifera commented on 1a01bdc Feb 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @thebigcrafter,

I regret to inform you that your plugin "oh-my-pmmp" (v1.1.0 submitted on 2022-02-06T12:51:28.000Z) has been rejected.

The installer should be done in an async task.

S1 — Do not block the main thread (37)

Except during startup/shutdown, plugins must avoid blocking the main thread with operations that cause the thread to wait for a signal. Apart from small-scale local file IO operations (compare with the extent used in PocketMine internals), no blocking operations (e.g. curl calls, MySQL queries, heavy SQLite calls, O(players) scanning) are allowed to be executed on the main thread, or to have the main thread wait for such operations.

Please resolve these issues and submit the plugin again.

This comment is posted here because this is the last commit when the released build was created.

Please sign in to comment.