Fixes #37654 - Use custom snippets to apply errata #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for acdfd45 is available at theforeman-foreman-documentation-preview-pr-3164.surge.sh The following output files are affected by this PR:
|
apinnick
requested changes
Jul 25, 2024
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
pr-processor
bot
added
Waiting on contributor
maximiliankolb
force-pushed
the
fix_3157_custom_snippets
branch
from
249187a
to
d27f32a
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
maximiliankolb
commented
Jul 26, 2024
There was a problem hiding this comment.
Rebased to "master" and applied all feedback. I also applied some feedback to the file where I "borrowed" the skeleton from. Ready for re-review @apinnick
Do you have a suggestion for a better title? The snippets should not be used to apply errata, but to customize applying errata on hosts.
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
apinnick
requested changes
Jul 28, 2024
guides/common/modules/proc_creating-custom-provisioning-snippets.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-provisioning-snippets.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
pr-processor
bot
added
Waiting on contributor
maximiliankolb
force-pushed
the
fix_3157_custom_snippets
branch
from
d27f32a
to
2dc30c4
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
maximiliankolb
commented
Jul 29, 2024
guides/common/modules/proc_creating-custom-provisioning-snippets.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-provisioning-snippets.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-custom-snippets-to-apply-errata.adoc
Outdated
Show resolved
Hide resolved
Refs 2064ec7457b3d41b72c2d48b7df9371f8b09d053 in katello Closes theforeman#3157
maximiliankolb
force-pushed
the
fix_3157_custom_snippets
branch
from
2dc30c4
to
acdfd45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs 2064ec7457b3d41b72c2d48b7df9371f8b09d053 in katello
Closes #3157
Do not cherry-pick.