-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37495 - unify sending the built state #10179
Conversation
985e09f
to
c4743bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From macros/docs perspective seems fine to me, just an idea inline:
0090781
to
faf14ef
Compare
I don't know if this is a bashism or POSIX shell, but you can indent EOF: #!/bin/sh
if true ; then
cat <<-EOF
Hello
World!
EOF
fi But you must use tabs, not spaces. |
And the indent() routine uses spaces :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are changes in the templates, should we update the snapshots?
Otherwise LGTM, though I'd like final approval from someone else, maybe @stejskalleos
If you would know which templates I need to change, I would simply do this. But currently I see no template test which fails. Do we need to activate something? |
Most of the time whenever we change templates, we run |
All tests are green @ofedoren |
No description provided.