Fixes #37592 - open Documentation in new tab in generic table #10222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this hasHelpPage flag on the Table used anywhere in any pages? I didn't see any component using it right now to test it. |
|
It was noticed when reviewing a pr in foreman_ansible, to test I added hasHelpPage in webpack/assets/javascripts/react_app/routes/Models/ModelsPage/index.js |
|
Tested that documentation in action toolbar for the table opens in a new tab with the change. Non-write Ack 👍🏼 |
stejskalleos
reviewed
Jul 1, 2024
| action: { | ||
| href: customHelpURL || helpURL(), | ||
| target: '_blank', | ||
| rel: 'noopener noreferrer', |
There was a problem hiding this comment.
According to this answer on StackOverflow, all browsers handle this automatically.
jeremylenz
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.