-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37825 - Upgrade Rails to 7.0 #10299
Open
ofedoren
wants to merge
8
commits into
theforeman:develop
Choose a base branch
from
ofedoren:rails-7.0
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8012399 - Browse repository at this point
Copy the full SHA 8012399View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21c1b11 - Browse repository at this point
Copy the full SHA 21c1b11View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7a9951 - Browse repository at this point
Copy the full SHA c7a9951View commit details -
Refs #37825 - Fix resource nesting for PreloadScopesBuilder
Without this patch Ansible-related scopes for Host::Managed.includes() would look like: [ { host_ansible_roles: :ansible_roles }, { ansible_role: [{ ansible_variables: [:lookup_values] }] } ], which for some reason worked before Rails 7. After this patch, it looks like: [ { host_ansible_roles: { ansible_role: [{ ansible_variables: [:lookup_values] }] } } ].
Configuration menu - View commit details
-
Copy full SHA for 188b129 - Browse repository at this point
Copy the full SHA 188b129View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5e9f73 - Browse repository at this point
Copy the full SHA b5e9f73View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf723dd - Browse repository at this point
Copy the full SHA cf723ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d9f64c - Browse repository at this point
Copy the full SHA 4d9f64cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a151be - Browse repository at this point
Copy the full SHA 1a151beView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.