Fixes #37580 - Auto-import new GPG keys on SLES #10339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tux93
force-pushed
the
fix_37580_sles-gpg-import
branch
from
1a80d7e
to
51c6ec5
Compare
sbernhard
force-pushed
the
fix_37580_sles-gpg-import
branch
from
51c6ec5
to
c059ecc
Compare
|
Should we also pass the option in https://github.com/theforeman/foreman/blob/develop/app/services/foreman/renderer/scope/macros/host_template.rb#L217 ? |
|
Good question, if I remember correctly the SLES default in update / upgrade is to disallow vendor change, meaning any updated packages would come from the same Repo they were originally installed from, which in turn means either the GPG key of that repo is already present or GPG check is disabled in the repo config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently introduced a change in foreman-rex to automatically import GPG keys on SLES, making it behave the same as EL distros.
This PR introduces the same change to snippets calling zypper in this repo.