Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use shared test workflow from theforeman/actions #672

Closed
wants to merge 1 commit into from
Closed

use shared test workflow from theforeman/actions #672

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 30, 2023

No description provided.

@evgeni evgeni force-pushed the shared-workflow branch 4 times, most recently from dbdbd1d to c34b616 Compare November 30, 2023 14:49
@evgeni evgeni mentioned this pull request Nov 30, 2023
Merged
@evgeni evgeni force-pushed the shared-workflow branch 6 times, most recently from 2483b81 to 2231771 Compare December 12, 2023 09:44
@ekohl
Copy link
Member

ekohl commented Jan 10, 2024

There's overlap with #672.

Some differences: mine continues running test/unit/foreman/access_permissions_test.rb. Yours renames the file as well. I'm not sure I like main and would probably prefer ci or test. Once we add flows like release I think that makes more sense.

@nofaralfasi
Copy link
Contributor

There's overlap with #672.

You probably meant #519 :)
Can we close this one?

@evgeni evgeni closed this Jan 29, 2024
@evgeni evgeni deleted the shared-workflow branch January 29, 2024 13:01
@evgeni
Copy link
Member Author

evgeni commented Jan 29, 2024

yes and yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ekohl @nofaralfasi