Fixes #37245 - 25 tests failing with "TypeError: Cannot read property 'perPage' of undefined" #698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #37245
This pull-request fixes #37245 by wrapping the mocked context in a React state.
Detailed problem description
This bug was introduced, when
useForemanContext
of ForemanContext.js was changed in theforeman/foreman@0b40a64In the commit,
useForemanContext
was split intouseForemanContext
anduseForemanSetContext
, which returngetForemanContext.context
andgetForemanContext.setContext
respectively.context
andsetContext
were provided by wrapping the original context object inReact.useState()
.In foreman_ansible, this change is not yet reflected.
getForemanContext
still returns the raw context object. Since the context object does not have the fieldscontext
andsetContext
,useForemanContext
anduseForemanSetContext
would returnundefined
, causing the tests to fail.This is fixed, by wrapping the context object given to
getForemanContext
inwithMockedProvider
of testHelper.js inReact.useState()
similar to ReactApp.js of Foreman.