Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37451 - Support Zeitwerk loader #718

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fixes #37451 - Support Zeitwerk loader #718

merged 1 commit into from
Sep 11, 2024

Conversation

ofedoren
Copy link
Member

@ofedoren ofedoren commented May 14, 2024 •
edited
Loading

@ofedoren ofedoren force-pushed the feat-37451-support-zeitwerk branch 2 times, most recently from a560fe6 to 6add953 Compare May 30, 2024 13:25
@ofedoren ofedoren force-pushed the feat-37451-support-zeitwerk branch from 6add953 to 2d3cf39 Compare June 22, 2024 14:28
@ofedoren ofedoren marked this pull request as ready for review June 22, 2024 14:28
@ofedoren ofedoren force-pushed the feat-37451-support-zeitwerk branch from 2d3cf39 to 7b63cd8 Compare July 8, 2024 15:01
@ofedoren ofedoren force-pushed the feat-37451-support-zeitwerk branch from 7b63cd8 to 9754805 Compare July 30, 2024 09:27
@ekohl
Copy link
Member

ekohl commented Sep 2, 2024

@ofedoren #724 contains another fix. Are you aware of that and can we converge on a single PR?

@ofedoren
Copy link
Member Author

ofedoren commented Sep 3, 2024

@ekohl, yeap, I'm aware, but it's easier for me to update this PR if I find something to address during local testing.

That PR differs in this 0ad16b6, which is simply another way of dealing with a file not being named as the constant it defines.

@ofedoren
Copy link
Member Author

ofedoren commented Sep 3, 2024

Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green (look test:foreman_ansible which was on Ruby 3 and Node 14, I think this plugin sometimes gives false-positives):
Screenshot_20240903_143351

@ekohl ekohl mentioned this pull request Sep 5, 2024
Closed
adamruzicka
adamruzicka requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the gemspec to allow tasks >= 10.0.0

@adamruzicka
Copy link
Contributor

And also rex >= 14.0.0

@ofedoren
Copy link
Member Author

Yeap, sorry, done.

@ekohl
Copy link
Member

ekohl commented Sep 10, 2024

Any idea why it's failing now?

@adamruzicka
Copy link
Contributor

Sigh, long live flaky tests. Packit is red, changes in packaging will be needed to make them green.

@adamruzicka adamruzicka merged commit 87fa094 into theforeman:master Sep 11, 2024
24 of 27 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ofedoren !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka requested changes

Assignees
No one assigned
Labels
Needs re-review
Projects
No open projects
Zeitwerk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofedoren @ekohl @adamruzicka