Fixes #37848 - Support Rails 7.0 #739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofedoren
force-pushed
the
feat-37848-support-rails-7
branch
from
25f7f2b
to
eadfd21
Compare
ekohl
reviewed
Oct 22, 2024
| @@ -7,30 +7,28 @@ | |||
| :defaults => { apiv: 'v2' }, | |||
| :apiv => /v2/, | |||
| :constraints => ApiConstraints.new(version: 2, default: true) do | |||
| constraints(:id => %r{[^\/]+}) do | |||
There was a problem hiding this comment.
Was this never needed? I can't find anything in the Rails upgrade guide relating to this.
There was a problem hiding this comment.
This causes the same issue as in theforeman/foreman_openscap#582 (comment)
ofedoren
force-pushed
the
feat-37848-support-rails-7
branch
from
eadfd21
to
50315a9
Compare
ofedoren
force-pushed
the
feat-37848-support-rails-7
branch
from
50315a9
to
170fcd2
Compare
|
@nofaralfasi I recall we talked about the CI failures of foreman_ansible and my impression is that this is the same failure we see in master. Have you had any chance to look closer at it? |
Yes, but unfortunately I couldn't figure out how to solve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.