Use theforeman-rubocop gem #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Apr 5, 2024
|
@ekohl could you spare a moment to review the latest changes? |
stejskalleos
reviewed
Jul 1, 2024
foreman_kubevirt.gemspec
Outdated
| @@ -15,7 +15,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.required_ruby_version = '>= 2.5', '< 4.0' | |||
|
|
|||
| s.add_development_dependency('theforeman-rubocop', '~> 0.0.6') | |||
| s.add_development_dependency('theforeman-rubocop', '~> 0.1.0') | |||
There was a problem hiding this comment.
In other plugins (Rex, Leapp, Ansible, Google), I don't see the foreman-robocop as a development dependency. Do we have to configure it, and does it have to be so version strict?
There was a problem hiding this comment.
theforeman/foreman_ansible#705 it does when this is merged ;)
And yes, we need rather strict versions due to changes in the underlying rubocop versions -- otherwise you get too much red
Choose to inherit just some cops, because i wanted to inherit rules from style_lenient.yml as well, i followed this https://github.com/theforeman/theforeman-rubocop?tab=readme-ov-file#choose-just-some-cops Also drop some cops from the .rubocop.yml config, because that was present in inherit-gem.
evgeni
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose to inherit just some cops, because i wanted to inherit rules from style_lenient.yml as well, i followed this
https://github.com/theforeman/theforeman-rubocop?tab=readme-ov-file#choose-just-some-cops
Also drop some cops from the .rubocop.yml config, because that was present in inherit-gem and upgraded theforeman-rubocop gem version from 0.0.6 -> 0.1.0
This is part of Rubocop standerdization, link for the reference:
https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239