Fixes #37689 - Add NVME controllers to hammer help #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2024
Lennonka
approved these changes
Jun 22, 2024
| ['boot_order', _('Device names to specify the boot order')] | ||
| ' key - ' + _('Key of the controller (e.g. 1000)')].flatten(1).join("\n")], | ||
| ['nvme_controllers', [_('List with NVME controllers definitions'), | ||
| ' type - ' + _('ID of the controller from VMware'), |
There was a problem hiding this comment.
It looks a bit strange that it's called a "type", but it requires an identifier. Is it an identifier of a controller type or a particular controller?
Suggested change
| ' type - ' + _('ID of the controller from VMware'), | |
| ' type - ' + _('ID of the controller type from VMware'), |
|
Thanks, @girijaasoni, could you please create a RM ticket in hammer project to attach it to this PR and https://projects.theforeman.org/issues/34839? |
girijaasoni
force-pushed
the
nvme-controllers
branch
from
7254b58
to
ae1ba95
Compare
girijaasoni
changed the title
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to update the hammer documentation to accodomate NVME controllers.
It can be merged after foreman PR and vpshere pr
RM Link https://projects.theforeman.org/issues/37689