Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36940 - Add SecureBoot support for arbitrary operating systems to "Grub2 UEFI" PXE loaders #821

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

goarsna
Copy link

@goarsna goarsna commented Nov 28, 2023

A new parameter 'bootloader_universe' has been added for tftp on the Smart Proxy side for the new "Grub2 UEFI SecureBoot (target OS)" PXE loader. This PR aims to add the new parameter to foreman-installer.

Refer to theforeman/smart-proxy#877 and theforeman/foreman#9864 for more information.

@goarsna
Copy link
Author

goarsna commented Dec 4, 2023

The usage is documented by theforeman/foreman-documentation#2145

@goarsna
Copy link
Author

goarsna commented Jan 25, 2024

Hi there,
can anybody tell me why the "Puppet / Test suite" check is stuck with status "Expected"?

manifests/tftp.pp Outdated Show resolved Hide resolved
@sbernhard
Copy link
Contributor

[test puppet-foreman_proxy]

Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goarsna
Copy link
Author

goarsna commented Mar 10, 2024

Squashed and changed commit message to reflect current implementation. => Any objections against merging this?

@goarsna goarsna changed the title Fixes #36940 - New PXE loader "Grub2 UEFI SecureBoot (target OS)" Fixes #36940 - Add SecureBoot support for arbitrary operating systems to "Grub2 UEFI" PXE loaders Mar 11, 2024
@Gauravtalreja1
Copy link

/packit build

Copy link

No config file for packit (e.g. .packit.yaml) found in theforeman/puppet-foreman_proxy on commit 49517b7

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

2 similar comments
Copy link

No config file for packit (e.g. .packit.yaml) found in theforeman/puppet-foreman_proxy on commit 49517b7

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link

No config file for packit (e.g. .packit.yaml) found in theforeman/puppet-foreman_proxy on commit 49517b7

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@goarsna
Copy link
Author

goarsna commented Mar 18, 2024

@Gauravtalreja1 Is there a reason for triggering /packit build? I assume there is no config file for packit in this repository as the puppet module isn't packaged as RPM. Therefore /packit build is failing.

@goarsna
Copy link
Author

goarsna commented May 6, 2024

Given that I only changed "NBPs" to "Network Boot Programs" and that the tests were successful before, I assume the failing tests are not related to my changes.

@goarsna
Copy link
Author

goarsna commented Jul 16, 2024

FYI: @nofaralfasi and I had a discussion last week that resulted in some changes we want to implement on the Smart Proxy side which are summarized in the Smart Proxy PR. These changes also will affect this PR. Further updates will follow soonish / in the upcoming weeks (as soon as I have time to work on this again).

@goarsna
Copy link
Author

goarsna commented Aug 5, 2024

Rebased to head of master

@goarsna
Copy link
Author

goarsna commented Aug 5, 2024

One outcome of the above mentioned discussion was that the Bootloader Universe should not be configurable. Instead it will be a fixed folder inside the TFTP root. This has now been adjusted. With this, the only change left that will be introduced by this PR is that two new directories bootloader-universe and host-config are added to the TFTP root.

@goarsna goarsna force-pushed the 36940 branch 2 times, most recently from 892501b to 1aa114c Compare August 8, 2024 11:13
… to "Grub2 UEFI" PXE loaders

In the course of theforeman/foreman#9864 and theforeman/smart-proxy#877,
SecureBoot support for arbitrary operating systems has been added to the
"Grub2 UEFI" PXE loaders.
This patch adds the 'bootloader-universe' and 'host-config' directories
inside the TFTP root, that are both required by the aforementioned PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants