-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36940 - Add SecureBoot support for arbitrary operating systems to "Grub2 UEFI" PXE loaders #821
base: master
Are you sure you want to change the base?
Conversation
The usage is documented by theforeman/foreman-documentation#2145 |
Hi there, |
[test puppet-foreman_proxy] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Squashed and changed commit message to reflect current implementation. => Any objections against merging this? |
/packit build |
No config file for packit (e.g. For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
2 similar comments
No config file for packit (e.g. For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
No config file for packit (e.g. For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
@Gauravtalreja1 Is there a reason for triggering |
Given that I only changed "NBPs" to "Network Boot Programs" and that the tests were successful before, I assume the failing tests are not related to my changes. |
FYI: @nofaralfasi and I had a discussion last week that resulted in some changes we want to implement on the Smart Proxy side which are summarized in the Smart Proxy PR. These changes also will affect this PR. Further updates will follow soonish / in the upcoming weeks (as soon as I have time to work on this again). |
Rebased to head of master |
One outcome of the above mentioned discussion was that the Bootloader Universe should not be configurable. Instead it will be a fixed folder inside the TFTP root. This has now been adjusted. With this, the only change left that will be introduced by this PR is that two new directories |
892501b
to
1aa114c
Compare
… to "Grub2 UEFI" PXE loaders In the course of theforeman/foreman#9864 and theforeman/smart-proxy#877, SecureBoot support for arbitrary operating systems has been added to the "Grub2 UEFI" PXE loaders. This patch adds the 'bootloader-universe' and 'host-config' directories inside the TFTP root, that are both required by the aforementioned PRs.
A new parameter 'bootloader_universe' has been added for tftp on the Smart Proxy side for the new "Grub2 UEFI SecureBoot (target OS)" PXE loader. This PR aims to add the new parameter to foreman-installer.
Refer to theforeman/smart-proxy#877 and theforeman/foreman#9864 for more information.