ASoC: Intel: sof_rt5682: Add support for nvl_max98360a_rt5682 - #5897
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the NVL SOF/ASoC ACPI match table to use a NVL-specific RT5682 “default” machine id and corresponding driver data, aligning NVL behavior with the existing PTL pattern for runtime topology filename fixups (codec/amp suffix selection).
Changes:
- Switch NVL RT5682 “default” entry from a generic
sof_rt5682drv_name to an NVL-specificnvl_rt5682_defid. - Change NVL RT5682 topology selection from SSP-based quirks to codec/amp-name-based quirks using the
sof-nvlbase name. - Add the
nvl_rt5682_defplatform device id and driver_data (SSP0 codec, SSP1 amp, SSP2 BT offload) tosof_rt5682.c.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sound/soc/intel/common/soc-acpi-intel-nvl-match.c | Updates NVL RT5682 default machine entry to use NVL-specific drv_name and codec/amp-name topology fixups. |
| sound/soc/intel/boards/sof_rt5682.c | Adds nvl_rt5682_def platform id entry with NVL driver_data (codec/amp/BT SSP ports). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| .sof_tplg_filename = "sof-nvl-rt5682", /* the tplg suffix is added at run time */ | ||
| .tplg_quirk_mask = SND_SOC_ACPI_TPLG_INTEL_SSP_NUMBER | | ||
| SND_SOC_ACPI_TPLG_INTEL_SSP_MSB, | ||
| .drv_name = "nvl_rt5682_def", |
There was a problem hiding this comment.
Why you change the existing driver data instead of adding a new one?
There was a problem hiding this comment.
@bardliao the existing one doesn't seems to be matching with the one used for PTL. Not sure, how the behavior will be with it. Hence, instead of adding new, I changed the existing one to alingn with the working one in PTL.
There was a problem hiding this comment.
@bardliao the existing one doesn't seems to be matching with the one used for PTL. Not sure, how the behavior will be with it. Hence, instead of adding new, I changed the existing one to alingn with the working one in PTL.
@jairaj-arava Could you please add the same to the commit message? So that the maintainer can have better understanding about the change.
There was a problem hiding this comment.
@bardliao updated the commit message as suggested. Thanks
27c5ea7 to
eabecf4
Compare
This patch adds the driver data for rt5682 codec on SSP0 and max98360a speaker amplifiers on SSP1 for NVL platform. The existing one is not aligned with PTL. Hence, changed it to align with the working changes in PTL. Signed-off-by: Jairaj Arava <jairaj.arava@intel.com>
This patch adds the driver data for rt5682 codec on SSP0 and max98360a speaker amplifiers on SSP1 for NVL platform and aligned with PTL changes