Skip to content

schedule: add a function for finding userspace scherulers - #11109

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
lyakh:sched
Aug 27, 2026
Merged

schedule: add a function for finding userspace scherulers#11109
kv2019i merged 1 commit into
thesofproject:mainfrom
lyakh:sched

Conversation

@lyakh

@lyakh lyakh commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

scheduler_get_data() only finds scheduler data for kernel mode schedulers. Add a similar function for userspace schedulers.
part of #10945

scheduler_get_data() only finds scheduler data for kernel mode
schedulers. Add a similar function for userspace schedulers.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Copilot AI lite review requested due to automatic review settings August 20, 2026 14:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the scheduler data lookup API to support user-managed scheduler instances, and updates the Zephyr LL scheduler code to query the correct scheduler list when userspace LL scheduling is enabled.

Changes:

  • Introduce a shared scheduler_list_get_data() helper for looking up scheduler private data in a given scheduler list.
  • Add scheduler_get_user_data() to retrieve scheduler data from the userspace scheduler list.
  • Update Zephyr LL scheduler helpers to use scheduler_get_user_data() when CONFIG_SOF_USERSPACE_LL is enabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/schedule/zephyr_ll.c Uses the userspace scheduler data accessor when userspace LL scheduling is enabled.
src/include/sof/schedule/schedule.h Adds list-based lookup helper and a userspace scheduler data accessor.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/include/sof/schedule/schedule.h
@kv2019i

kv2019i commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

@lyakh Do you have the updated full series somewhere? I'm wondering where you need this? I remember I dropped variants like these earlier and looked up the data with another method. Maybe won't work for full DP/multicore, but something I'd like to double-check.

@lyakh

lyakh commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

@lyakh Do you have the updated full series somewhere? I'm wondering where you need this? I remember I dropped variants like these earlier and looked up the data with another method. Maybe won't work for full DP/multicore, but something I'd like to double-check.

@kv2019i I think it's mentioned in the PR description ;-)

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, in PR description the info was.

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh can you respond/resolve the copilot comment. Thanks !

@lyakh

lyakh commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

@lyakh can you respond/resolve the copilot comment. Thanks !

@lgirdwood done

@lyakh

lyakh commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

@lrudyX the CI failure doesn't seem logical for this PR, could you double-check? thanks!

@kv2019i
kv2019i merged commit 28b104f into thesofproject:main Aug 27, 2026
47 of 48 checks passed
@lyakh
lyakh deleted the sched branch August 27, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants