Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbl click bug fix (& loading class for image block), IE9 support (2d tra... #32

Closed
wants to merge 1 commit into from

Conversation

vedmant
Copy link

@vedmant vedmant commented Dec 17, 2014

Hi, there!

I've found some bugs and fixed them.

  1. If you click twice while image is loading it will cause two figure blocks appearing. I've added "loading" class to image block, it can be also used for adding loading spinner.
  2. IE9 doesn't support 3d transitions, I've added test for 3d transitions and in case browser doesn't support it it will use 2d transitions instead. There is another story with mouse cursors, but my solution uses separate css file and I didn't add it for pull request.

PS: I'm novice with Forks & Pull Request, if I've done it wrong please tell me.

@tholman
Copy link
Owner

tholman commented Aug 8, 2015

Sorry for dropping the ball so much on this one. The double click was fixed with - #34

You're spot on about the ie9 thing, I might just use 2d transforms for all of them, and forget about 3d all together!

@tholman tholman closed this Aug 8, 2015
@vedmant
Copy link
Author

vedmant commented Aug 8, 2015

I don't think using only 2d transform is good idea, it works much slower compared to 3d.

@tholman
Copy link
Owner

tholman commented Aug 8, 2015

Feels good to me. Added backface visibility hidden, to keep hardware compositing too. Its not like we're transforming 1000 images at once either ;)

@vedmant
Copy link
Author

vedmant commented Aug 8, 2015

When I tried only 2d it worked not so smooth, mayte your hardware is more powerful. I selected your plugin exactly because it worked smoother than others.

@tholman
Copy link
Owner

tholman commented Aug 8, 2015

There is no reason why backface visibility combined with 2d transform would be any slower. But feel free to use the version you have, and not update to the changed one!

@vedmant
Copy link
Author

vedmant commented Aug 8, 2015

That's just what I experienced when was fixing IE9 problem, that's why I've added test for 3d.

@vedmant vedmant deleted the vedmant branch August 8, 2015 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants