Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CS package detail endpoint #853

Closed
wants to merge 4 commits into from
Closed

Add CS package detail endpoint #853

wants to merge 4 commits into from

Conversation

Oksamies
Copy link
Contributor

Add package detail endpoint

refs TS-1682

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #853 (519ad02) into master (2e67279) will decrease coverage by 0.15%.
The diff coverage is 81.13%.

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
- Coverage   91.78%   91.63%   -0.15%     
==========================================
  Files         242      244       +2     
  Lines        7069     7175     +106     
  Branches      687      689       +2     
==========================================
+ Hits         6488     6575      +87     
- Misses        486      504      +18     
- Partials       95       96       +1     
Impacted Files Coverage Δ
django/thunderstore/repository/models/package.py 94.73% <66.66%> (-2.94%) ⬇️
.../thunderstore/repository/models/package_version.py 91.05% <66.66%> (-2.64%) ⬇️
...hunderstore/api/cyberstorm/views/package_detail.py 67.74% <67.74%> (ø)
...hunderstore/api/cyberstorm/serializers/__init__.py 100.00% <100.00%> (ø)
...thunderstore/api/cyberstorm/serializers/package.py 100.00% <100.00%> (ø)
...go/thunderstore/api/cyberstorm/serializers/user.py 100.00% <100.00%> (ø)
...ango/thunderstore/api/cyberstorm/views/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Base automatically changed from cb-base to master July 5, 2023 12:52
Add package detail endpoint

refs TS-1682
Move dependcy testing in CS package_detail endpoint to an separate test
The previous implementation was fragile, with this commit its solid

refs TS-1678
Add some helper properties to the Package and PackageVersion model with
the intention of them being used with DRF Serializers down the line.

Refs TS-1682
@Oksamies Oksamies closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants