[BACK-2958] [BACK-2960] [BACK-3076] Add ability to execute clinic merge plans #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddkazakov
force-pushed
the
tk-execute-migration-plan
branch
from
b1f517f
to
79df27e
Compare
lostlevels
previously approved these changes
Aug 2, 2024
| return err | ||
| } | ||
| if res == nil { | ||
| return fmt.Errorf("patient list result not defined") |
There was a problem hiding this comment.
Is there a reason sometimes the error is defined in the errors package and sometimes defined inline?
There was a problem hiding this comment.
The errors in the errors package ought to wrapped so when they bubble up to the API layer we return the correct http code. All other errors which bubble up with result in a 500 response, which is intended here.
toddkazakov
changed the title
[BACK-3076] Persist executable merge plans for audit logging purposes
toddkazakov
changed the title
toddkazakov
force-pushed
the
tk-execute-migration-plan
branch
from
d9e1343
to
9b3abd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.