Skip to content

Commit

Permalink
*: pid to id (#448)
Browse files Browse the repository at this point in the history
  • Loading branch information
overvenus authored Dec 22, 2016
1 parent 61c8c6a commit d585960
Show file tree
Hide file tree
Showing 9 changed files with 323 additions and 283 deletions.
255 changes: 147 additions & 108 deletions _vendor/vendor/github.com/pingcap/kvproto/pkg/kvrpcpb/kvrpcpb.pb.go

Large diffs are not rendered by default.

256 changes: 128 additions & 128 deletions _vendor/vendor/github.com/pingcap/kvproto/pkg/pdpb/pdpb.pb.go

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ import:
- package: github.com/pingcap/check
version: ce8a2f822ab1e245a4eefcef2996531c79c943f1
- package: github.com/pingcap/kvproto
version: 679b4719adb44bb55780ad2480f29a0f234b039e
version: 4416a5a5ad6f6c63c27904c85c67c26133059127
subpackages:
- pkg/coprocessor
- pkg/eraftpb
Expand Down
70 changes: 36 additions & 34 deletions server/api/bindata_assetfs.go

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions server/api/member.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func (h *memberDeleteHandler) ServeHTTP(w http.ResponseWriter, r *http.Request)

type leaderInfo struct {
Addr string `json:"addr"`
Pid int64 `json:"pid"`
ID uint64 `json:"id"`
}

type leaderHandler struct {
Expand All @@ -125,7 +125,7 @@ func (h *leaderHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {

ret := leaderInfo{
Addr: leader.Addr,
Pid: leader.Pid,
ID: leader.Id,
}
h.rd.JSON(w, http.StatusOK, ret)
}
2 changes: 1 addition & 1 deletion server/api/member_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,5 +181,5 @@ func (s *testMemberAPISuite) TestMemberLeader(c *C) {
var got leaderInfo
json.Unmarshal(buf, &got)
c.Assert(got.Addr, Equals, leader.GetAddr())
c.Assert(got.Pid, Equals, leader.GetPid())
c.Assert(got.ID, Equals, leader.GetId())
}
6 changes: 3 additions & 3 deletions server/api/templates/docs/pd.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,10 @@
"type": "string",
"description": "The leader's client URLs."
},
"pid": {
"id": {
"type": "integer",
"format": "int64",
"description": "The leader's process id."
"format": "uint64",
"description": "The leader's id."
}
}
},
Expand Down
5 changes: 2 additions & 3 deletions server/leader.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
package server

import (
"os"
"path"
"sync/atomic"
"time"
Expand Down Expand Up @@ -121,13 +120,13 @@ func (s *Server) GetLeader() (*pdpb.Leader, error) {
}

func (s *Server) isSameLeader(leader *pdpb.Leader) bool {
return leader.GetAddr() == s.GetAddr() && leader.GetPid() == int64(os.Getpid())
return leader.GetAddr() == s.GetAddr() && leader.GetId() == s.ID()
}

func (s *Server) marshalLeader() string {
leader := &pdpb.Leader{
Addr: s.GetAddr(),
Pid: int64(os.Getpid()),
Id: s.ID(),
}

data, err := leader.Marshal()
Expand Down

0 comments on commit d585960

Please sign in to comment.