Fixing the issue that mkfs.xfs was not added to the base image #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @VladyslavTkachenkoDesy . Thanks for this contribution. Looks like you need to sign the DCO. The XFS binaries here are different from the others included as they aren't statically built. Can these binaries be statically built like the others? I also found that ❯ docker run -it --rm --entrypoint /sbin/fsck.xfs rootio
exec /sbin/fsck.xfs: no such file or directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added mkfs.xfs support to the base image
Why is this needed
To be able to create xfs partition
#131
Fixes: #
copy to the image the mkfs.xfs command with all libs
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Fixes a bug
Checklist:
I have: