Implement custom pool object in order to allow clustered computing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 8, 2017 18:03
assert should be used for debug (as tests) only, not for input validation.
… be used as multiprocess or dask-distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys. I'm planning using your library with expensive functions, and I have configured a little cluster in my lab using dask-distributed.
I have made some improvement in your code and I have added a parameter so we can provide a custom Pool object.
In that way, I can use distributed Client object and distribute the functions accross all the cluster workers.
I have improved a bit the code too, which is now pep8 compliant, use the logging module and stuffs.