-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions #709
Add GitHub Actions #709
Conversation
A note: you'll likely need to specifically enable GH Actions on the PR to allow it to run. |
Cool, this looks like it'll fit my existing processe well. Might need to change branch name at some point based on the outcome of #710 but that'll be easy enough to do later. No need for any versioning automation here, I think that could go in a separate release-oriented workflow, along with NuGet publishing etc. Just a couple suggested modifications:
Thanks again! |
Sure -- happy to do that here or in a follow-up. Since you're looking at GitHub flow and a main branch + releases, you may want to either:
But if you're happy to do that as a later step, I'm happy to leave it be for now 👍
Sure, I've got no hang-ups on names and that seems reasonable enough.
You've got it! Normally I do those in separate PRs because I like seeing the build pass before merging. 😆 However I'll do that right now. |
dotnet is the default name; ci.yml is preferred by the author.
By suggestion of the maintainer.
Alright, changes made per suggestions -- happy to do more beyond this, just tag me with any input/needs you have! |
@tmenier I think you may need to allow GitHub Actions to run on this -- I can see it on my local, but not on this one. I think there may be a few failures to address and I'd like to see them here so I can review them with you if they happen. |
Sorry I've disappeared for a while, I have a bad habit of doing that when life gets busy. This is still very much on my radar and I hope to get to it merged in conjunction with some other work related to #710 very soon. Thanks again! |
Supports #695.
Starting with the out of the box template commit (which of course won't work) and then tweaking it from there.