Skip to content

fix(cli): preserve missing API key diagnostic - #552

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/cli-command-failure-analysis-262d
Draft

fix(cli): preserve missing API key diagnostic#552
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/cli-command-failure-analysis-262d

Conversation

@cursor

@cursor cursor Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • raise CliDiagnosticExit from the missing-API-key request hook so command-failure telemetry records Together API key missing instead of bare status 1
  • preserve the existing user-facing message and exit status
  • add an integration test covering the full launcher path

Verification

  • TOGETHER_TELEMETRY_DISABLED=1 TOGETHER_API_KEY=test-key uv run pytest tests/cli tests/unit/test_cli_telemetry.py (514 passed)
  • uv run ruff check src/together/lib/cli/__init__.py tests/cli/test_command_telemetry.py
  • uv run ruff format --check src/together/lib/cli/__init__.py tests/cli/test_command_telemetry.py
  • uv run pyright src/together/lib/cli/__init__.py tests/cli/test_command_telemetry.py
Open in Web View Automation 

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.3-Flash) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant