fix for checkAndEvaluateMath as it currently crashed on boolean expressions #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63a96a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jorenbroekema
requested changes
Aug 1, 2023
|
The test brought something to light I think. The test fails, because it would return the booleans as strings I think? So maybe another approach is needed? |
Co-authored-by: thomasmattheussen <thomas.mattheussen@gmail.com>
jorenbroekema
force-pushed
the
fix/check-and-evaluatemath-booleans
branch
from
bf7283e
to
63a96a2
Compare
|
I pushed a new commit as a proposal on how we could tackle this, but I have changed the changeset to be a minor, as this could technically be a breaking change for users. What do you think? |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a slightly better way to handle it?