Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for more advanced math expressions #49

Merged
merged 2 commits into from
May 14, 2024

Conversation

jorenbroekema
Copy link
Member

@jorenbroekema jorenbroekema commented Mar 7, 2023

fixes #48

TODO:

  • implement the feature, so tests pass :)
  • allowlist for which units resolve to pixels, and allow combining those with px, but not other units like % etc. --> actually all units resolve to pixels 🤯 even %, so it always works

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

🦋 Changeset detected

Latest commit: 06a147d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/sd-transforms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jorenbroekema jorenbroekema merged commit 3ab8d64 into main May 14, 2024
2 checks passed
@jorenbroekema jorenbroekema deleted the math-same-units branch May 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow math expressions were all values have the same unit, or px/unitless
1 participant