fix androidX legacy dependencies... #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a hacky way to detect when to use the legacy dependecies from androidX.
diegojimenes
force-pushed
the
fix-androidx-legacy-dependecies
branch
from
9682253
to
d6c3a4b
Compare
|
also, people might need to run this command |
|
I think this PR should be checked :) @tolu360 now React Native 0.60 has released & supported Android-X. A few of modules upgraded. There are two options:
|
|
Yes, @congnguyen91. This should keep compatibility with both, for now. |
|
Hi guys! I would take a look at this PR, thanks @diegojimenes! I do prefer we keep support for both for the nearest future - I may release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a hacky way to detect when to use the legacy dependecies
from androidX.
let me know if there is a better way.