Fix leak off api key by loading from manifest xml #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @diegojimenes, I am sorry I have been away and just looking at this. I am working on releasing a v4, a week from now, at the latest. However, if you used early versions of the library, you would recall the keys have always been in the manifest files - I am not sure they were safer there and some users wanted to be able to do different things for different environments and didn't have any easy way to do so at the time. Chime in with your thoughts in the replies if you can. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i had a little problem with play store because the key of google places was be exposed in the gradle properties, so i move it to android manifest. but i don't know if is a correct approach.