prefer ~/.local/share/ as the data directory (WIP) #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
==========================================
- Coverage 72.32% 72.27% -0.05%
==========================================
Files 33 34 +1
Lines 9579 9794 +215
==========================================
+ Hits 6928 7079 +151
- Misses 2651 2715 +64
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dash is used as the separator for similarity with the path already used by FAPI (~/.local/share/tpm2-tss/). Signed-off-by: Mantas Mikulėnas <grawity@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For newly created DBs, following the general practice on Linux (and tpm2-tss, which already uses ~/.local/share/tpm2-tss/ for FAPI).
The old ~/.tpm_pkcs11/ path is supposed to be still used if it exists, assuming I got the logic right, but I'm really not sure if the db.c part of it is correct.