Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use core::error::Error for no-std #2346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use core::error::Error for no-std #2346

wants to merge 1 commit into from

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Oct 8, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

rust-lang/rust#103765

Changes

Removed feature gate for decorating error types with core::error.

Testing

run all checks.

laggui
laggui reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Though it looks like the feature is not stabilized yet

@antimora
Copy link
Collaborator Author

Awesome! Though it looks like the feature is not stabilized yet

I forgot we maintain two last versions. This works only with the latest stable Rust. So we'll have to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laggui laggui laggui left review comments

@nathanielsimard nathanielsimard Awaiting requested review from nathanielsimard

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antimora @laggui